This repository was archived by the owner on Mar 13, 2025. It is now read-only.
Fixed bugs and lint errors. #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
suggested changes
May 29, 2021
There was a problem hiding this comment.
Thank you @MadOPcode.
All the issue looks fixed, there is just a couple of question regarding the code, could you please have a look below:
…and fixed lint errors.
maxceem
approved these changes
May 31, 2021
There was a problem hiding this comment.
Thank you @MadOPcode for taking care of the sidebar for small screens.
2 issues from the list are not fixed:
❌ Use inline SVG plugin instead of creating components manually for SVG files. (let me know if there are any difficulties with it)
❌ It's preferable to not use background SVG, and inline SVG files, this way all the images would be loaded immediately. (let me know if there are any difficulties with it)
But we would make them as a separate PR, as this PR is already has a lot of good fixes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.